Add plot functionality to AUROC and ROC metrics #1490
Conversation
alexkrz
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
|
Not sure why the docs test is failing. Docs could be build successfully on my local machine. |
There was a problem hiding this comment.
Already looking good :)
Could you please also add test to this file:
https://github.com/Lightning-AI/metrics/blob/master/tests/unittests/utilities/test_plot.py
This is actually my first time contributing to an open source project and I am new to working with pytest. I have now included tests for BinaryAUROC and MulticlassAUROC plots. I would be glad if you could have a look on it. |
for more information, see https://pre-commit.ci
…etrics into feature/roc-curve
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 216 216
Lines 11344 11396 +52
======================================
+ Hits 9969 9997 +28
- Misses 1375 1399 +24 |
for more information, see https://pre-commit.ci
What does this PR do?
Fixes part of #1406
Currently, plot functionality is added to modular metrics BinaryAUROC, MulticlassAUROC, MultilabelAUROC and BinaryROC.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃